convert magma power series rings #38794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 6f957f1; changes) is ready! 🎉 |
tscrim
added
t: enhancement
s: positive review
c: interfaces
and removed
s: needs review
labels
|
Thanks Travis. Were you able to test that it works ? Sadly, I have no machine running both sage and magma. |
|
No, I don't have access to magma now. I just looked at the changes as I thought you had tested it. I will revert back to needs review then. |
|
yes, that's better indeed. Sorry |
|
It seems that |
|
The interface seems to be broken for Galois groups. Also the changes here seem to trigger an issue in |
|
This is getting closer to be ready. |
|
this is ready for review. Testing all sage with with ticket and |
5 tasks
tscrim
approved these changes
Jan 29, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2025
this is trying to allow the conversion of magma's series rings
also refactors the conversion of polynomial rings
This needs to be tested, if you have magma.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38794
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 31, 2025
this is trying to allow the conversion of magma's series rings
also refactors the conversion of polynomial rings
This needs to be tested, if you have magma.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38794
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 3, 2025
this is trying to allow the conversion of magma's series rings
also refactors the conversion of polynomial rings
This needs to be tested, if you have magma.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38794
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 4, 2025
this is trying to allow the conversion of magma's series rings
also refactors the conversion of polynomial rings
This needs to be tested, if you have magma.
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38794
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is trying to allow the conversion of magma's series rings
also refactors the conversion of polynomial rings
This needs to be tested, if you have magma.
📝 Checklist