Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube enhancements #687

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Youtube enhancements #687

wants to merge 3 commits into from

Conversation

abetis
Copy link
Contributor

@abetis abetis commented Apr 11, 2018

The PR includes:

  • youtubeParameters option added to allow people use different video sizes and other formatting options in the generated HTML code
  • YouTube start playing time is now supported in both the editor and the formatter
  • Unit tests updated according to the API changes
  • Added unit tests to check YouTube start time

@abetis abetis mentioned this pull request Apr 11, 2018
Closed
brunoais
brunoais approved these changes Apr 15, 2018
View reviewed changes
Copy link
Collaborator

@brunoais brunoais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are some details in terms of coherence I am in doubt... Which I'll leave to @samclarke

@brunoais brunoais requested a review from samclarke April 15, 2018 10:29
@abetis abetis mentioned this pull request Apr 16, 2018
Open
@live627 live627 added this to the v3.0.0 milestone Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoais brunoais brunoais approved these changes

@samclarke samclarke Awaiting requested review from samclarke

Assignees

@samclarke samclarke

Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@abetis @brunoais @live627 @samclarke