Upgrade core dependencies + dev node variable #213
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While I updated the frontend dependencies at the start of Fall 2023, I put off doing the same for the backend due to issues I had with updating Elasticsearch; it turns out that it was way easier to update than expected, and I just had to tweak my yarn installation a little bit. Now there's no longer a node version mismatch between both of our search repos, and while a few of our dependencies are still end-of-life, all of our core ones should be supported at least for the next few years.
Tickets
This one
Contributors
@Lucas-Dunker
Feature List
template.env
that I forgot aboutNotes
Changes like this are very prone to break things!!! Ideally at least half of the team should verify that these changes work before deploying to staging and prod:
.nvmrc
withfnm use
yarn
to get the new dependencies; if there's any errors, try deletingnode_modules
and rerunning the commandyarn test
yarn scrape
, ideally both a cached one and a live oneyarn dev
, and execute a few example queries to make sure everything is working as expectedReviewers
Primary:
@pranavphadke1 @sebwittr
Secondary:
@soulwa @ananyaspatil @Anzhuo-W