Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade core dependencies + dev node variable #213

Closed
wants to merge 7 commits into from

Conversation

Lucas-Dunker
Copy link
Member

Purpose

While I updated the frontend dependencies at the start of Fall 2023, I put off doing the same for the backend due to issues I had with updating Elasticsearch; it turns out that it was way easier to update than expected, and I just had to tweak my yarn installation a little bit. Now there's no longer a node version mismatch between both of our search repos, and while a few of our dependencies are still end-of-life, all of our core ones should be supported at least for the next few years.

Tickets

This one

Contributors

@Lucas-Dunker

Feature List

  • Update our node, babel, graphQL, and Elasticsearch dependencies, as well as their corresponding types
  • Add a dev variable to template.env that I forgot about

Notes

Changes like this are very prone to break things!!! Ideally at least half of the team should verify that these changes work before deploying to staging and prod:

  • Use the new node version in .nvmrc with fnm use
  • Run yarn to get the new dependencies; if there's any errors, try deleting node_modules and rerunning the command
  • Run all tests with yarn test
  • Try out a scrape using yarn scrape, ideally both a cached one and a live one
  • Run a graphQL instance locally with yarn dev, and execute a few example queries to make sure everything is working as expected

Reviewers

Primary:
@pranavphadke1 @sebwittr

Secondary:
@soulwa @ananyaspatil @Anzhuo-W

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 80.439%. remained the same
when pulling 8c7b605 on LD_upgrade_CCA_Dependencies
into d81126a on master.

@mehallhm mehallhm mentioned this pull request Sep 24, 2024
13 tasks
@mehallhm mehallhm mentioned this pull request Oct 21, 2024
@mehallhm
Copy link
Contributor

PR superseded by #231

@mehallhm mehallhm closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants