Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade #231

Merged
merged 25 commits into from
Nov 11, 2024
Merged

Dependency upgrade #231

merged 25 commits into from
Nov 11, 2024

Conversation

mehallhm
Copy link
Contributor

@mehallhm mehallhm commented Oct 21, 2024

UPDATE: Changed Elasticsearch note
UPDATE 2: Changed Twilio Verify to use the v2 API

Purpose

Upgrades "trivial" dependencies to latest version across any major, minor, or patch version that required minimal modification. The goal was to pick all the low hanging fruit required to get a stable version of the codebase running on Node 22. There still are outdated things, notably ESLint and Apollo Server #222 however they currently still fully work (just depreciated and end-of-life respectively) which require much more invasive upgrades.

Tickets

Associated with #219 and #213. Closes PRs #226, #227, #228, #229, #230 and closes #223

Contributors

@mehallhm

Feature List

  • Changed base Node version to Node 22
  • Upgraded Babel and associated packages
  • Upgraded Jest and regenerated associated snapshots
  • Upgraded Prisma and regenerated associated snapshots
  • Upgraded Husky and migrated to their new pre-commit hook declaration method
  • Removed nodemon, switch instead to node's native watch mode for development
  • Updated Twilio Verify to use the V2 API

Notes

This PR seems much larger than it actually is due to updates in Jest changing how they format snapshots and changes in Prettier in how they format code. As such, the majority of changes are trailing commas and curly brace shifts.

Because the nature of dependencies touches the entire code base, EVERYONE should review and approve before this gets merged.

Additionally, the prod version of Elasticsearch should not have to be updated but needs to be... at some point. No additional code changes will be needed in order to support a newer version on the same major release (7.x.x, latest at time of writing is 7.24.0)

Reviewers

Primary:
@ananyaspatil

Secondary:
@cherman23 @nickpfeiffer05 @Anzhuo-W

@mehallhm mehallhm requested a review from ananyaspatil October 21, 2024 19:40
@mehallhm mehallhm self-assigned this Oct 21, 2024
@mehallhm mehallhm mentioned this pull request Oct 21, 2024
13 tasks
@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2024

Coverage Status

coverage: 80.533%. remained the same
when pulling 922ad98 on dependency-upgrade
into 6cd914e on master.

@mehallhm mehallhm marked this pull request as ready for review October 23, 2024 15:20
Copy link
Contributor

@ananyaspatil ananyaspatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace nodemon with Node 22 Watch mode
3 participants