-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency upgrade #231
Merged
Merged
Dependency upgrade #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ananyaspatil
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: Changed Elasticsearch note
UPDATE 2: Changed Twilio Verify to use the v2 API
Purpose
Upgrades "trivial" dependencies to latest version across any major, minor, or patch version that required minimal modification. The goal was to pick all the low hanging fruit required to get a stable version of the codebase running on Node 22. There still are outdated things, notably ESLint and Apollo Server #222 however they currently still fully work (just depreciated and end-of-life respectively) which require much more invasive upgrades.
Tickets
Associated with #219 and #213. Closes PRs #226, #227, #228, #229, #230 and closes #223
Contributors
@mehallhm
Feature List
Notes
This PR seems much larger than it actually is due to updates in Jest changing how they format snapshots and changes in Prettier in how they format code. As such, the majority of changes are trailing commas and curly brace shifts.
Because the nature of dependencies touches the entire code base, EVERYONE should review and approve before this gets merged.
Additionally, the prod version of Elasticsearch should not have to be updated but needs to be... at some point. No additional code changes will be needed in order to support a newer version on the same major release (7.x.x, latest at time of writing is 7.24.0)
Reviewers
Primary:
@ananyaspatil
Secondary:
@cherman23 @nickpfeiffer05 @Anzhuo-W