-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply analysis tutorial fixes #1298
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
===========================================
- Coverage 89.30% 78.36% -10.94%
===========================================
Files 119 119
Lines 8721 8728 +7
===========================================
- Hits 7788 6840 -948
- Misses 933 1888 +955
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
There are lot's of unrelated changes due to executing all the cells in the notebook. I commented the specific files. For those files, please add only the relevant changes (typo fixes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the big diff that you get by executing all the notebook cells. Please add only the typo change in the one sentence as diff.
you can do so by either undoing all changes in this notebook and then change only the one line. Or by doing a selective git add -p filename
and then select only the relevant change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, adding the image changes is OK because there were missing before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above: please add only the relevant changes, not the entire execution of all cells. Thanks!
Minor typo and formatting fixes. Added output to notebook on crafting summary statistics.