Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply analysis tutorial fixes #1298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions tutorials/03_density_estimators.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"One option is to use one of set of preconfigured density estimators by passing a string in the `density_estimator` keyword argument to the inference object (`NPE` or `NLE`), e.g., \"maf\" to use a Masked Autoregressive Flow, of \"nsf\" to use a Neural Spline Flow with default hyperparameters.\n"
"One option is to use one of the preconfigured density estimators by passing a string in the `density_estimator` keyword argument to the inference object (`NPE` or `NLE`), e.g., \"maf\" to use a Masked Autoregressive Flow, of \"nsf\" to use a Neural Spline Flow with default hyperparameters.\n"
]
},
{
Expand Down Expand Up @@ -101,7 +101,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"It is also possible to pass an `embedding_net` to `posterior_nn()` which learn summary\n",
"It is also possible to pass an `embedding_net` to `posterior_nn()` which learns summary\n",
"statistics from high-dimensional simulation outputs. You can find a more detailed\n",
"tutorial on this in [04_embedding_networks](04_embedding_networks.md).\n"
]
Expand Down Expand Up @@ -129,13 +129,6 @@
"\n",
"See more information on the [Reference API page](https://sbi-dev.github.io/sbi/reference/models/#sbi.neural_nets.density_estimators.ConditionalDensityEstimator)."
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": []
}
],
"metadata": {
Expand Down
250 changes: 213 additions & 37 deletions tutorials/08_crafting_summary_statistics.ipynb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, adding the image changes is OK because there were missing before.

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions tutorials/12_iid_data_and_permutation_invariant_embeddings.ipynb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the big diff that you get by executing all the notebook cells. Please add only the typo change in the one sentence as diff.
you can do so by either undoing all changes in this notebook and then change only the one line. Or by doing a selective git add -p filename and then select only the relevant change.

Large diffs are not rendered by default.

Loading