[2.x] Replace Compilation Timestamp with content hashes #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
changed the title
Friendseeker
force-pushed
the
content-hashing
branch
from
a2fffad to
1f05eea
Compare
eed3si9n
reviewed
Oct 5, 2024
eed3si9n
reviewed
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces compilation timestamp used in
detectAPIChangeswith two types of content hashes.bytecodeHashcomputes content hash of all class files associated with a source file.extraBytecodeHashis a hash of all upstream classes'sbytecodeHash, similar to #1388 (comment).For a non-macro class, we employ
bytecodeHashas a direct replacement of compilation timestamp.For a macro class, there are cases for which the macro has same
bytecodeHashafter the macro is recompiled but the macro's upstream dependency is changed hence the macro expansion result would be different. Therefore if a class is macro we also compare byextraBytecodeHashto detect such change.