This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Cleanups and a small fix #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions were using scx_rq local variable to cache rq->scx and dequeue_task_scx() was taking scx_rq as an argument. "scx_rq->" isn't any shorter than "rq->scx." and the inconsistency adds to confusion. Let's always use rq.
No need for this to be a separate variable. - As this removes symbol name collision, rename test_rq_online() to scx_rq_online(). - [un]likely() annotation moved from its users to scx_rq_online(). - On/offline status should agree with ops->cpu_on/offline(). In the existing code, the two states could deviate when rq_on/offline_scx() were called for sched domain updates. Fix it so that they always agree.
The two being separate variables only makes things cumbersome. - Move scx_dsp_buf into scx_dsp_ctx and dynamically allocate the latter. - Rename scx_dsp_ctx->buf_cursor to ->cursor for brevity.
Byte-Lab
approved these changes
May 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rq->scx.flags.scx_dsp_ctx.