Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Cleanups and a small fix #203

Merged
merged 4 commits into from
May 17, 2024
Merged

Cleanups and a small fix #203

merged 4 commits into from
May 17, 2024

Commits on May 17, 2024

  1. scx: Always use rq->scx instead of scx_rq 

    Some functions were using scx_rq local variable to cache rq->scx and
dequeue_task_scx() was taking scx_rq as an argument. "scx_rq->" isn't any
shorter than "rq->scx." and the inconsistency adds to confusion. Let's
always use rq.
    @htejun
    htejun committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3baae12 View commit details
    Browse the repository at this point in the history

  2. scx: Replace scx_cpu_online percpu var with SCX_RQ_ONLINE flag 

    No need for this to be a separate variable.

- As this removes symbol name collision, rename test_rq_online() to
  scx_rq_online().

- [un]likely() annotation moved from its users to scx_rq_online().

- On/offline status should agree with ops->cpu_on/offline(). In the existing
  code, the two states could deviate when rq_on/offline_scx() were called
  for sched domain updates. Fix it so that they always agree.
    @htejun
    htejun committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3a44769 View commit details
    Browse the repository at this point in the history

  3. scx: Allocate scx_dsp_ctx together with scx_dsp_buf 

    The two being separate variables only makes things cumbersome.

- Move scx_dsp_buf into scx_dsp_ctx and dynamically allocate the latter.

- Rename scx_dsp_ctx->buf_cursor to ->cursor for brevity.
    @htejun
    htejun committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7d196e5 View commit details
    Browse the repository at this point in the history

  4. scx/common.bpf.h: Sync from SCX repo

    @htejun
    htejun committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6a5cf23 View commit details
    Browse the repository at this point in the history