move navigation in hasSessionInProgress #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/UUI-683/add-support-for-page-refresh #271 +/- ##
===========================================================================
Coverage 100.00% 100.00%
===========================================================================
Files 14 14
Lines 640 641 +1
Branches 169 170 +1
===========================================================================
+ Hits 640 641 +1 ☔ View full report in Codecov by Sentry. |
bogdan-niculescu-sch
requested review from
hunger-programmer and
michal-oleniacz-stp
hunger-programmer
approved these changes
Apr 3, 2024
hunger-programmer
merged commit b17a705
into
feat/UUI-683/add-support-for-page-refresh
4 checks passed
bogdan-niculescu-sch
added a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If brands are adding Identity calls in either callback or on page load lifecycle, calls can happen in parallel, leading to some calls taking place without the correct cookies and leading to user logout.
Moving navigation to hasSessionInProgress to
getSession().thenseems to have fixed this problem