feat(permissionless batches): recovery mode after permissionless batches #1073
Conversation
…initial batch from which point the existing local chain will be overridden with the blocks from the pipeline
jonastheis
changed the title
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Semgrep found 1 Risk: Affected versions of golang.org/x/net, golang.org/x/net/http2, and net/http are vulnerable to Uncontrolled Resource Consumption. An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames. Fix: Upgrade this library to at least version 0.23.0 at go-ethereum/go.mod:145. Reference(s): GHSA-4v7x-pqxf-cx7m, CVE-2023-45288 Ignore this finding from ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2. |
cmd/geth/main.go
Outdated
| @@ -39,7 +41,6 @@ import ( | |||
| "github.com/scroll-tech/go-ethereum/log" | |||
| "github.com/scroll-tech/go-ethereum/metrics" | |||
| "github.com/scroll-tech/go-ethereum/node" | |||
| "go.uber.org/automaxprocs/maxprocs" | |||
There was a problem hiding this comment.
reverted. seems my IDE reordered automatically
| // Double check: even though we just built the block, make sure it is valid. | ||
| if err = bc.validator.ValidateState(fullBlock, statedb, receipts, gasUsed); err != nil { | ||
| bc.reportBlock(fullBlock, receipts, err) | ||
| return nil, NonStatTy, fmt.Errorf("error validating block %d: %w", fullBlock.Number().Uint64(), err) |
There was a problem hiding this comment.
This is not that expensive to run but I can't see a reason that this would ever fail.
There was a problem hiding this comment.
Well we're creating/assembling the block just before, but during development and testing it actually happened that this process was faulty and this method caught it. That's why I left it in.
jonastheis
changed the base branch from
syncUpstream/active
to
jt/l1-follower-mode
jonastheis
changed the base branch from
jt/l1-follower-mode
to
syncUpstream/active
1. Purpose or design rationale of this PR
This PR implements a recovery mode after batches have been submitted permissionlessly in the context of permissionless batches. During permissionless mode the L2 network will not produce any valid/canonical L2 chain. Batches can be submitted by anyone directly to the L1.
This PR extends the
L1 follower modeto be able to recover state from any given L1 block height--da.recovery.initiall1blockand batch index--da.recovery.initialbatchto a given L2 end block--da.recovery.l2endblock, while overriding any existing local state of the node.Additionally, it allows to re-sign the read blocks with
--da.recovery.signblocksso that once the sequencer comes back online a valid canonical L2 chain can again be created from the permissionless committed batches.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?