Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for minification in totalVI #3061

Merged
merged 14 commits into from
Dec 4, 2024
Merged
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
pre-commit-ci[bot] committed Dec 4, 2024
commit 316c061e05186ec5a3cb70d56f16dc852a516e2a
8 changes: 4 additions & 4 deletions src/scvi/model/_totalvi.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt we want to have a warning for setup_anndata: "TOTALVI is supposed to work with MuData"

Original file line number Diff line number Diff line change
@@ -1234,10 +1234,10 @@ def setup_anndata(
%(returns)s
"""
warnings.warn(
"We recommend using setup_mudata for multi-modal data."
"It does not influence model performance",
DeprecationWarning,
stacklevel=settings.warnings_stacklevel,
"We recommend using setup_mudata for multi-modal data."
"It does not influence model performance",
DeprecationWarning,
stacklevel=settings.warnings_stacklevel,
)
setup_method_args = cls._get_setup_method_args(**locals())
batch_field = fields.CategoricalObsField(REGISTRY_KEYS.BATCH_KEY, batch_key)