Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for minification in totalVI #3061

Merged
merged 14 commits into from
Dec 4, 2024
Merged

Conversation

canergen
Copy link
Member

Add support of minification in totalVI

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 88.97638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.61%. Comparing base (cfa3d83) to head (162a570).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/model/base/_base_model.py 86.84% 5 Missing ⚠️
src/scvi/model/utils/_minification.py 80.00% 4 Missing ⚠️
src/scvi/module/_totalvae.py 91.17% 3 Missing ⚠️
src/scvi/data/_utils.py 66.66% 1 Missing ⚠️
src/scvi/model/_totalvi.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3061      +/-   ##
==========================================
+ Coverage   84.60%   84.61%   +0.01%     
==========================================
  Files         178      178              
  Lines       15052    15125      +73     
==========================================
+ Hits        12734    12798      +64     
- Misses       2318     2327       +9     
Files with missing lines Coverage Δ
src/scvi/model/_scanvi.py 95.23% <100.00%> (-0.69%) ⬇️
src/scvi/model/_scvi.py 95.91% <100.00%> (+0.08%) ⬆️
src/scvi/model/_utils.py 89.93% <100.00%> (+0.20%) ⬆️
src/scvi/model/base/__init__.py 100.00% <100.00%> (ø)
src/scvi/model/base/_de_core.py 97.50% <100.00%> (+0.16%) ⬆️
src/scvi/model/utils/__init__.py 100.00% <100.00%> (ø)
src/scvi/data/_utils.py 85.11% <66.66%> (-0.43%) ⬇️
src/scvi/model/_totalvi.py 87.29% <92.30%> (+0.46%) ⬆️
src/scvi/module/_totalvae.py 88.01% <91.17%> (+0.47%) ⬆️
src/scvi/model/utils/_minification.py 84.37% <80.00%> (-8.96%) ⬇️
... and 1 more

@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Dec 1, 2024
eval-multivi/output.png Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt we want to have a warning for setup_anndata: "TOTALVI is supposed to work with MuData"

src/scvi/model/_scanvi.py Show resolved Hide resolved
src/scvi/model/_totalvi.py Show resolved Hide resolved
src/scvi/model/_totalvi.py Show resolved Hide resolved
src/scvi/model/base/_base_model.py Show resolved Hide resolved
src/scvi/model/utils/_minification.py Show resolved Hide resolved
src/scvi/module/_totalvae.py Show resolved Hide resolved
@ori-kron-wis ori-kron-wis added the cuda tests Run test suite on CUDA label Dec 4, 2024
@canergen canergen merged commit 337ec87 into main Dec 4, 2024
11 of 12 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Dec 4, 2024
canergen added a commit that referenced this pull request Dec 4, 2024
…totalVI) (#3077)

Backport PR #3061: feat: Support for minification in totalVI

Co-authored-by: Can Ergen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda tests Run test suite on CUDA on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants