Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved IsIsomorphicSemigroup Method #1023

Merged
merged 23 commits into from
Jul 29, 2024

Conversation

tillman-froehlich
Copy link
Contributor

Added a better method to compute whether finite simple semigroups are isomorphic which is faster than the current one.

Copy link
Collaborator

@reiniscirpons reiniscirpons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR! One minor change and a question about speedup and were good to merge I think.

tst/standard/attributes/isomorph.tst Show resolved Hide resolved
gap/attributes/isomorph.gi Outdated Show resolved Hide resolved
gap/attributes/isomorph.gi Outdated Show resolved Hide resolved
@james-d-mitchell
Copy link
Collaborator

Just to also add that with this PR:

gap> R := ReesMatrixSemigroup(AlternatingGroup([1 .. 5]),
> [[(), ()], [(), (1, 3, 2, 4, 5)]]);;
gap> S := ReesMatrixSemigroup(AlternatingGroup([1 .. 5]),
> [[(1, 5, 4, 3, 2), ()], [(1, 4, 5), (1, 4)(3, 5)]]);;
gap> IsIsomorphicSemigroup(R, S); time;
15

and without

gap> R := ReesMatrixSemigroup(AlternatingGroup([1 .. 5]),
> [[(), ()], [(), (1, 3, 2, 4, 5)]]);;
gap> S := ReesMatrixSemigroup(AlternatingGroup([1 .. 5]),
> [[(1, 5, 4, 3, 2), ()], [(1, 4, 5), (1, 4)(3, 5)]]);;
gap> IsIsomorphicSemigroup(R, S); time;
117

So this change is definitely worth making!

@james-d-mitchell james-d-mitchell merged commit fecdb4c into semigroups:main Jul 29, 2024
15 checks passed
@james-d-mitchell
Copy link
Collaborator

Thanks @awesometillman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants