This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Update godot-rust and egui #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented the new texture delta functionality - Broke the font changing functionality in the example (as this has since changed)
|
I added the changes to get the textures to work. Now that the textures seem to be rendered properly. Unfortunately, I also couldn't quite figure out how to modify the font-definitions. |
Closed
…xture from only the start of the insertion and not as a sub-rect of the texture.
jacobsky
reviewed
May 26, 2022
… completed the last couple of TODOs in the PR. egui_helpers::progress_bar() signature has changed due to egui version bump.
jacobsky
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godot-rust
Updates to
masterversion. Implements new API from godot-rust/gdnative#872.This API is still in flux despite merged, so we could also skip that commit and wait until an API lands in a released version.
egui
I tried updating egui 0.15 to egui 0.18. For the most part, this worked, however:
TODO(bromeon)in the code for places where I wasn't sure, would appreciate a review/correction.This PR allows edits by maintainers, feel free to push other commits on top.