-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use Mutex / Condvar from std. #140
base: master
Are you sure you want to change the base?
Conversation
Would be great if this gets merged. |
What is the point of doing this? If we're going to support non-parking-lot mutexes this should use antidote rather than reimplementig non-poisoning locks manually. |
I took a look at this crate. It's more or less the same code. So the question is what would be more comfortable for you? Maintain two projects or one. These two approaches are better than parking lot with their own dependencies. |
|
See above |
Why are these two approaches better than parking lot with its own dependencies? |
Because having other dependencies means they need to be compiled during build which means longer build times. If this is already included in the stdlib this would not be the case and I could get a smaller docker image. |
How much does this change affect your build times and docker image size? |
Enough that I want to have as few dependencies as possible. |
Fix #138