fix aptos user uid #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpeng-sh
reviewed
Jul 25, 2024
| @@ -24,7 +24,7 @@ RUN apt-get update && \ | |||
| apt-get install -y --no-install-recommends curl ca-certificates procps && \ | |||
| rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| RUN adduser --uid 1000 --home /aptos --gecos '' --disabled-password aptos | |||
| RUN adduser --uid 1002 --home /aptos --gecos '' --disabled-password aptos | |||
There was a problem hiding this comment.
Just curious, why the change in UID? Does aptos require the UID to be 1002? Or is 1000 overriding something else?
There was a problem hiding this comment.
Want to keep them separate from other designations:
https://github.com/shinamicorp/tf-infra/blob/main/modules/sui_node/main.tf#L76-L83
https://www.notion.so/shinami/b5e1e9e16b7b49ffad58ca9cee09034b?v=77af7c369abb4ec0b57adc674009355e
ivanpeng-sh
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.