Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aptos user uid #9

Merged
merged 3 commits into from
Jul 25, 2024
Merged

fix aptos user uid #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ea02f5
fix aptos user uid
jachen-sh Jul 23, 2024
fd56253
expose public network port
jachen-sh Jul 23, 2024
5745159
expose metrics port instead of admin
jachen-sh Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RUN apt-get update && \
apt-get install -y --no-install-recommends curl ca-certificates procps && \
rm -rf /var/lib/apt/lists/*

RUN adduser --uid 1000 --home /aptos --gecos '' --disabled-password aptos
RUN adduser --uid 1002 --home /aptos --gecos '' --disabled-password aptos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why the change in UID? Does aptos require the UID to be 1002? Or is 1000 overriding something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to keep them separate from other designations:
https://github.com/shinamicorp/tf-infra/blob/main/modules/sui_node/main.tf#L76-L83
https://www.notion.so/shinami/b5e1e9e16b7b49ffad58ca9cee09034b?v=77af7c369abb4ec0b57adc674009355e

WORKDIR /aptos

# https://github.com/aptos-labs/aptos-core/blob/a72ef8a716ecf3ab207c8377cb94c9c5aedaf5b4/crates/aptos/src/node/local_testnet/mod.rs#L236
Expand Down Expand Up @@ -58,6 +58,6 @@ COPY --from=builder \
USER aptos

EXPOSE 8080
EXPOSE 9102
EXPOSE 9101

ENTRYPOINT ["aptos-node"]
Loading