Add business id to cronjob chart #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullah-sl
changed the title
cronjob/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| description: Helm chart with simple cronjob template | |||
| name: cronjob | |||
| version: 0.9.0 | |||
| version: 0.10.0 | |||
There was a problem hiding this comment.
remember update version before merge
| @@ -10,6 +10,8 @@ kind: CronJob | |||
| metadata: | |||
| name: {{ .Values.name }} | |||
| namespace: {{ .Release.Namespace }} | |||
| labels: | |||
| businessid: {{ required "businessid must be provided" .Values.businessid | quote }} | |||
There was a problem hiding this comment.
why add required here, should add required in all businessid field?
There was a problem hiding this comment.
This is the entry point, so I believe checking here would be enough.
thomaslishopline
previously approved these changes
Jul 30, 2024
ThomasKwan-shopline
previously approved these changes
Aug 7, 2024
abdullah-sl
dismissed stale reviews from ThomasKwan-shopline and thomaslishopline
via
60fe520
This reverts commit 60fe520.
ThomasKwan-shopline
previously approved these changes
Aug 7, 2024
thomaslishopline
previously approved these changes
Aug 7, 2024
neal-sl
previously approved these changes
Aug 7, 2024
abdullah-sl
dismissed stale reviews from neal-sl, thomaslishopline, and ThomasKwan-shopline
via
be74b37
ThomasKwan-shopline
approved these changes
Aug 8, 2024
thomaslishopline
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.