get_album: fix invalid track list artists (#617) #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed invalid artists info for get_album from #617 issue.
Bug was a result of my changes in #612.
This is a flexColumn for an artist:
it was skipped in parsing, because it did not have
navigationEndpoint
andtext
was empty. "Plays" column has been used as an artist instead. I removed emptytext
check. Now it will be used as unrecognized artist column. Thenparse_song_artists
method will returnNone
and in the end inget_album
method if artist track isNone
, then primary album artist will be used. So it will work exactly as in 1.7.3 and before.Closes #617.