Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_album: fix invalid track list artists (#617) #618

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

czifumasa
Copy link
Collaborator

@czifumasa czifumasa commented Jul 11, 2024

Fixed invalid artists info for get_album from #617 issue.

Bug was a result of my changes in #612.

This is a flexColumn for an artist:

{
"musicResponsiveListItemFlexColumnRenderer": {
  "text": {},
 "displayPriority": "MUSIC_RESPONSIVE_LIST_ITEM_COLUMN_DISPLAY_PRIORITY_HIGH"
 }
}

it was skipped in parsing, because it did not have navigationEndpoint and text was empty. "Plays" column has been used as an artist instead. I removed empty text check. Now it will be used as unrecognized artist column. Then parse_song_artists method will return None and in the end in get_album method if artist track is None, then primary album artist will be used. So it will work exactly as in 1.7.3 and before.

Closes #617.

@sigma67
Copy link
Owner

sigma67 commented Jul 11, 2024

@MarvinSchenkel can you please review?

@MarvinSchenkel
Copy link
Contributor

@MarvinSchenkel can you please review?

Yep all good, just tested with the feature branch of this PR.

@sigma67 sigma67 merged commit 8cc72e3 into sigma67:main Jul 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_album returns invalid artist data for track items in 1.7.4
3 participants