Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update German messages.json to add missing i18n #7158

Closed
wants to merge 1 commit into from

Conversation

ottlinger
Copy link

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A npm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Added i18n keys for not translated contents and harmonized existing i18n to use the same words, fix minor formatting issues (whitespace)

and harmonize existing i18n to use the same words,
fix minor formatting issues (whitespace)
@scottnonnenberg-signal
Copy link
Contributor

Thanks for taking the time to look in detail at our German strings! However, we only update the en/messages.json file in this repository, and for every release we download the latest localized strings from our translation system. I've passed your German string updates to our localization folks, and I am going to close this PR.

@maba4891
Copy link

maba4891 commented Feb 7, 2025

Hey,
German Language Manager here! I'll review your suggested changes and integrate them where necessary. Thanks for your contribution @ottlinger!

@ottlinger
Copy link
Author

Alright, I'll leave my fork open and look for changes in the upstream project. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants