(On hold) Handle new "tags" field in Language Forge #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now LfMerge can create a CmPossibilityList in FLEx data if it doesn't already exist, which will allow us to create the custom field that will store LF tags in FLEx data.
rmunn
force-pushed
the
feature/canonical-lf-tags
branch
from
64d456d to
703fdb4
Compare
FLEx projects will now have a custom list created if it doesn't already exist, using a GUID reserved for this purpose, for storing Language Forge tags. We should probably put something in the list description like "Please do not edit this list", but since it will be re-created if it doesn't exist, that's probably not needed.
For handling LF tags, and possibly other LF fields in the future, we can now create a canonical custom field that references a CmPossibilityList created from canonical values embedded in the resource fork of the app.
Still to do: LF -> FW direction
This will allow us to re-use this logic in the code that sets the LF Tags custom field in the LF -> FW direction.
|
This needs testing locally before it's actually ready to merge, but the bulk of the logic is there now so I'm un-marking this PR as draft. Any subsequent commits will be bug fixes, rather than major logic changes. |
Missed a closing tag.
Can't create a custom field outside a Unit Of Work in FW.
8 tasks
rmunn
changed the title
|
Needs testing and corresponding LF work; on hold until I am able to work on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once sillsdev/web-languageforge#1008 is implemented, LF data is going to start including a "tags" field, which LfMerge will need to handle.
This is a draft PR which I'll be working on at the same time as the implementation of the LF feature. They'll both need to be merged together, so this one will remain in draft status until both PRs are done.
This change is