-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry Tagging #1008
Comments
Great summary of our conversation! I will just add that if there is ever any kind of entry data that is not synced with FLEx, that that limitation should be communicated with the user the first time(s) that he creates said data. I would like to encourage the development team to always ensure all data is syncable. (Though a short-term no-sync limitation during the development of a feature would be acceptable). |
Here's what I wrote in #1153, which I created when I hadn't noticed that this card exists: One user wanted the ability to mark certain entries, and then have a filter that would show only the marked entries. Something like the "star" feature in Gmail. Then a filter could be used to see only the starred entries, or only the unstarred ones. This would involve a new boolean property on entries in MongoDB, or perhaps we could plan ahead and make it a string so that we could have multiple label colors à la Trello (red, blue, green...). There would also be UI to mark or unmark ("star" or "unstar") the entry on the entry view page, and the star would show up in the entry list view on the left. The star status would not be sent in a Send/Receive operation; this would be in Language Forge only and would not show up in FieldWorks. (Unless user feedback suggests that they want to see the star status in FieldWorks as well, in which case we'd track that work in a separate issue). Alternatives:
|
Also, Alex Larkin said:
I'm copying that comment over here as well so the whole conversation is visible here. |
Design decisions reached after discussing this with Chris yesterday:
|
Sounds good! Exciting stuff. A note regarding machine translation: machines can still botch single-word translations, because words often have more than one sense. And the machine may not have the needed context. (Granted, translating all the colors together should help with context.) Here are some examples, though my main concerns are orange and to a lesser extent, star. Star:
Orange:
Yellow:
Green:
Blue:
Also, languages divide up colors differently. For example, our English blue is divided up into two colors in Korean and Russian. Those interested can check out this fascinating short paper on the subject I imagine most of the translations will probably be fine. Could we do the machine translation and then message all of our Transifex volunteers and ask them to check them? (Is there a way to do that?) Another option is to check translations in Dictionaries, like in WordReference.com. though that could be tedious. Are we going to translate into the five non-English, non-semantic-domain-only languages listed on production? Thanks! |
Figured out a UI for displaying multiple tags on an entry in the list view. We currently have an orange bar if an entry has comments. For tags, I figured we would add other color bars. Problem is, the orange bar is implemented with a CSS And here's the same list entry with red and yellow tags added: The CSS used to add the red and yellow tags was: box-shadow: inset -5px 0px yellow, inset -10px 0px red Since the pixel values will be dependent on how many tags are on an entry, we can't use static CSS for this. Instead, I'll add a BTW, I used https://svelte.dev/repl/f01054bf77854e7ca2b4f2582703f397?version=3.44.1 to experiment with the CSS. The immediate feedback of editing the style and seeing it "live" on the right was a great development experience. |
sillsdev/LfMerge#142 will track the Send/Receive portion of this feature. |
The |
The UI changes for the entry tagging feature manifest in a number of places:
|
I have observed that users would like the ability to tag entries in a general sense for later processing. This is similar to the "star" in Gmail. The user wants to be able to "star" or "tag" an entry to remember it, and then be able to filter based upon that tag or star. @rmunn suggested we provide a set of color tags or stars, not just one star.
@alex suggested that we consider how these tags could be easily transferred back into FLEx, and we decided that a custom field option list was the best way to do that.
The text was updated successfully, but these errors were encountered: