[Feat] Add feedback and about to viewer #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# Unit Tests75 tests 75 ✅ 6s ⏱️ Results for commit ed0a4cf. ♻️ This comment has been updated with latest results. |
myieye
force-pushed
the
feat/add-feedback-and-about-to-viewer
branch
from
926410a to
b32b327
Compare
myieye
force-pushed
the
feat/add-feedback-and-about-to-viewer
branch
from
b32b327 to
5dda76f
Compare
hahn-kev
requested changes
Oct 15, 2024
use the version from the assembly as the feedback version
|
pushed my own change to modify the version being used when reporting feedback |
Merged
hahn-kev
previously approved these changes
Oct 16, 2024
hahn-kev
previously approved these changes
Oct 16, 2024
…and-about-to-viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add's the feedback button to the viewer as well as an about button + dialog.
The dialog appears automatically on a user's first visit to the viewer.
Then there's a funky commit: b725184
We're currently embedding global styles (e.g. tailwind and any other global styles) in a
<style global>element in the root component. Unfortunately, it seems that Svelte's preprocessing is pretty fragile when it comes to using global styles. So, that approach has forced me to use various workarounds (a funky style rewrite hack to get some dark-mode styles to work, splitting up style declarations, making more styles global than actually desired) and finally it totally blocked me from using the tailwind typography plugin.So, this commit tries another approach that's at least equally as funky, BUT it works 🤷. And remember, this is only the viewer 😉, so it's the only thing using this weird approach where as FWL doesn't use anything funky AND now benefits from not having to write styles in a way that makes global happy.
FYI The viewer is currently broken and being fixed in #1105