Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize FW Lite ProjectData.Id #1170

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

hahn-kev
Copy link
Collaborator

Previously it was a mix of LangProjectId or Lexbox project Id, or a random guid, depending on how the project was created, now it'll match the lexbox project Id, unless it was created locally. Additionally there will be a sync error if the projects don't have a matching FwProjectId

…track the FieldWorks project Id. when doing a sync the fw project ids must match otherwise there's an error
isolate SyncFailsWithMismatchedProjectIds test to not break other tests
@hahn-kev hahn-kev requested a review from rmunn October 28, 2024 05:11
Copy link

github-actions bot commented Oct 28, 2024

C# Unit Tests

75 tests  ±0   75 ✅ ±0   5s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4c23d7b. ± Comparison against base commit 6a0d473.

♻️ This comment has been updated with latest results.

rmunn
rmunn previously approved these changes Oct 28, 2024
@hahn-kev hahn-kev merged commit f72f3e0 into develop Oct 28, 2024
13 checks passed
@hahn-kev hahn-kev deleted the chore/project-data-id-is-lexbox-id branch October 28, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants