CRDT sync handles semantic domains #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are now working. I'm going to rebase on top of |
rmunn
force-pushed
the
feat/crdt-sync-semantic-domains
branch
from
08c286c to
8716ebe
Compare
C# Unit Tests75 tests 75 ✅ 5s ⏱️ Results for commit 0885ca6. ♻️ This comment has been updated with latest results. |
- Add GetSemanticDomain() to read API - CreateSemanticDomain now returns the created object - Add UpdateSemanticDomain() to write API - Add DeleteSemanticDomain() to write API - Add UpdateSemanticDomainProxy class - Add SemanticDomainSync class - Sync semantic domains in CRDT-FW sync service
rmunn
force-pushed
the
feat/crdt-sync-semantic-domains
branch
from
8716ebe to
b16957c
Compare
hahn-kev
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1216.
Currently this PR is based on top of #1203 for convenience so I can more easily bootstrap the semantic domain implementation using the parts of speech sync. Once #1203 is merged, this PR should auto-base onto develop instead.
We now sync semantic domains just like we sync parts of speech. There are similar issues with deciding how Predefined should be set; I'm currently setting it to
truefor any semantic domain coming from FW, because custom semantic domains will be rare. But ultimately we'll want to keep a list of GUIDs around and match the incoming semdom against that list of GUIDs; if it's not on the list then Predefined should be false instead.