Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/improve e2e tests in gha #1270

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Nov 25, 2024

As discussed in our team meeting:

  • We want Playwright tests to run on frontend changes. This is the easiest way to do that. I could have gotten smart and filtered out viewer changes. But, I wasn't convinced that it was worth it.
  • Also as discussed, we'll just disable the test (in Firefox) that uses a header not supported in Firefox. A client-side only fix might be worthwhile in the future.

Copy link

UI unit Tests

12 tests   12 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit e963418.

Copy link

C# Unit Tests

90 tests  ±0   90 ✅ ±0   4s ⏱️ -1s
14 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e963418. ± Comparison against base commit a525563.

@hahn-kev hahn-kev merged commit a598cae into develop Nov 26, 2024
14 checks passed
@hahn-kev hahn-kev deleted the chore/improve-e2e-tests-in-gha branch November 26, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants