Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate project code to ID cache on project deletion #929

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Jul 8, 2024

Otherwise when you delete a project and create a new one with the same code, it will return errors from GraphQL queries until the project code to project ID cache expires, because it will still be trying to use the GUID of the old project that was deleted.

Fixes #781.

@rmunn rmunn self-assigned this Jul 8, 2024
@rmunn rmunn requested a review from hahn-kev July 8, 2024 05:20
Copy link

github-actions bot commented Jul 8, 2024

C# Unit Tests

52 tests  ±0   52 ✅ ±0   5s ⏱️ -1s
10 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit da26fa2. ± Comparison against base commit e99ed21.

♻️ This comment has been updated with latest results.

Otherwise when you delete a project and create a new one with the same
code, it will return errors from GraphQL queries until the project code
to project ID cache expires, because it will still be trying to use the
GUID of the old project that was deleted.
@rmunn rmunn force-pushed the bug/781-invalidate-code-to-id-cache-on-delete branch from 0d83a8f to da26fa2 Compare July 8, 2024 08:57
@rmunn
Copy link
Contributor Author

rmunn commented Jul 8, 2024

Merge conflict fixed by rebasing on top of new develop state.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, I had to check because I though I already wrote code to invalidate that cache, not sure what I was thinking of.

@rmunn rmunn merged commit ca160ca into develop Jul 11, 2024
8 checks passed
@rmunn rmunn deleted the bug/781-invalidate-code-to-id-cache-on-delete branch July 11, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidate project code to ID on delete
2 participants