Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Tidy up asset build #211

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 26, 2022

Issue silverstripe/gha-ci#37

Looks like files have been added straight to the dist folder and ignoring the src folder for a while, so deleting the dist folder then running yarn build failed

main.min.css wasn't being used by Page.ss which has <% require themedCSS('dist/css/main.css') %> - main.css is minified already.

Fix https://github.com/silverstripe/cwp-starter-theme/runs/7509555512?check_suite_focus=true
git diff found modified files when it should not have: D css/main.min.css D fonts/FontAwesome.otf D fonts/fontawesome-webfont.eot D fonts/fontawesome-webfont.svg D fonts/fontawesome-webfont.ttf D fonts/fontawesome-webfont.woff D fonts/fontawesome-webfont.woff2 D fonts/glyphicons-halflings-regular.eot D fonts/glyphicons-halflings-regular.svg D fonts/glyphicons-halflings-regular.ttf D fonts/glyphicons-halflings-regular.woff D fonts/glyphicons-halflings-regular.woff2 D images/application.png D images/external-link.png D images/facebook.png D images/favicon.ico D images/logo.png D images/logoOrig.png D images/newzealand-government-footer.png D images/page_excel.png D images/page_white_acrobat.png D images/page_white_zip.png D images/page_word.png D images/twitter.png

@GuySartorelli GuySartorelli merged commit e832d1f into silverstripe:3.2 Jul 27, 2022
@GuySartorelli GuySartorelli deleted the pulls/3.2/dist branch July 27, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants