Broken builds from initial github actions CI config PRs

[GuySartorelli]

We've added github actions CI but many of the builds are broken. We have decided to merge in CI config and treat the broken builds separately, so this issue is just to track fixing the broken builds.

Module	Build	Reason	Effort
silverstripe/silverstripe-elemental-bannerblock	build link	failing behat test php 8 mysql 8 (was re-run)	medium
silverstripe/silverstripe-externallinks	build link	broken behat test	medium
silverstripe/silverstripe-ckan-registry	build link	behat failure	medium
silverstripe/silverstripe-asset-admin	build link	behat 7.3 failed after re-run	medium
silverstripe/silverstripe-subsites	build link	failing behat tests	medium
silverstripe/silverstripe-graphql	build link	behat php 7.4 asset-admin 1.11.x-dev failed after 2x re-run (not same failure as asset-admin or recipe-cms)	medium
silverstripe/silverstripe-login-forms	build link	sass-lint linting admin scss	medium
silverstripe/cwp-agencyextensions	build link	failing yarn test	medium
silverstripe/cwp-watea-theme	build link	can't build css	medium
silverstripe/cwp-search	build link	prefer-lowest solr connection issue	hard
silverstripe/silverstripe-contentreview	build link	wrong version of node - have tried both 6 and 10, pure guess module want 6 while admin uses 10	hard
symbiote/silverstripe-advancedworkflow	build link	git diff failing in js test	hard
silverstripe/cow	build link	out of date requirements	hard
silverstripe/recipe-solr-search	build link	unit test failure	hard
silverstripe/silverstripe-behat-extension	build link	phplinting job only cannot install, likely conflict cow has with symfony and behat requirements	hard
silverstripe/silverstripe-config		codesniffer not added to composer.json as dev dependency	easy
silverstripe/doorman		codesniffer not added to composer.json as dev dependency	easy
silverstripe/recipe-blog	build link	failing unit tests, probably phpunit 5 on silverstripe-comments possible needs to require a theme	medium - do last
silverstripe/recipe-cms	build link	failing graphql unit test, same failure as on graphql 3.7 pr	medium - do last
silverstripe/recipe-kitchen-sink	build link	various failures	medium - do last
silverstripe/silverstripe-installer	build link	pdo utf8mb3 unit test failure + same failure as on graphql 3.7 pr	medium - do last
silverstripe/recipe-content-blocks	build link	prefer-lowest a mess, 7.4 plus missing graphql FakeResolveInfo	medium - do last
silverstripe/recipe-core	build link	prefer-lowest a mess, 7.4 plus various unit test failures	medium - do last

Guy PRs

• MNT Add codesniffer as a dev dependency. doorman#42
• MNT Add codesniffer as a dev dependency silverstripe-config#63
• MNT Fix linting issues silverstripe-testsession#76
• MNT Ignore vendor dirs when linting sass silverstripe-login-forms#117
• DEP Update symfony/yaml dependency cow#219
• DEP Update symfony/yaml dependency cow#218
• FIX Don't throw exception for bad dates with mysql 8.0 cwp#312
• FIX Allow new DB fields when flushing silverstripe-graphql#485
• DEP Update symfony/console dependency cow#220
• DEP Update symfony/console dependency cow#221
• MNT Run phpcbf to fix linting issues cow#222
• FIX Require installer for recipe-blog gha-generate-matrix#23
• MNT Refactor permission check unit tests silverstripe-graphql#487
• MNT Wait for toast to appear for behat in new CI silverstripe-asset-admin#1280
• MNT Reorder unit tests to fix CI failure recipe-core#74

Steve PRs

• BACKPORT - Handle MySQL exception silverstripe-framework#10412 < fix for running kitchen-sink 4.10 on php 8.1
• MNT Handle DatabaseExceptions thrown by PHP 8.1 cwp#311
• MNT Remove yarn test script cwp-agencyextensions#75
• ENH Add php version to outputted composer.json #38
• ENH Automatically create hardcoded list gha-generate-matrix#20
• MNT Fix CI cwp-watea-theme#149
• MNT Use node 10 silverstripe-contentreview#166
• FIX Output git diff gha-run-tests#6
• FIX Only use git diff gha-run-tests#7
• MNT Remove map file symbiote/silverstripe-advancedworkflow#463
• MNT Delete map file silverstripe-login-forms#118
• FIX Move files to client directory silverstripe-externallinks#82
• FIX Move files to client directory silverstripe-subsites#483
• MNT Fix behat test silverstripe-elemental-bannerblock#89
• MNT Conflict older versions of lumberjack recipe-blog#34
• MNT Backport FakeResolveInfo silverstripe-graphql#488
• FIX Ensure injectable version of queuedjobs is installed recipe-solr-search#12
• MNT Add GitHub Actions CI silverstripe-framework#10416
• MNT Fix unit test silverstripe-fulltextsearch#328
• MNT Use php7.3 compatible version for frameworktest recipe-kitchen-sink#16
• MNT Fix typos silverstripe-installer#328
• MNT Better detection of status-flags in behat silverstripe-asset-admin#1281
• MNT Handle early versions of webonyx/graphql-php silverstripe-graphql#489
• MNT Use php7.3 syntax on TestOnly object silverstripe-elemental#992
• MNT Use simple matrix recipe-kitchen-sink#17
• FIX Require PHP 7.4 compatible version of silverstripe/auditor cwp-core#109
• FIX Ensure client directory exists before running git diff gha-run-tests#9
• MNT Skip test if Page class missing silverstripe-framework#10420
• MNT Require frameworktest silverstripe-admin#1327
• MNT Fix phpcs error silverstripe-config#64
• FIX Use usleep for fractions of a second silverstripe-behat-extension#216
• FIX Include default_sort in sortChildren method silverstripe-asset-admin#1282
• FIX Disable xdebug extension if not running phpcoverage #39
• ENH Re-enable silverstripe phpcoverage gha-generate-matrix#24
• MNT Re-enable phpcoverage silverstripe-framework#10421
• MNT Use php 7.4 for prefer-lowest recipe-kitchen-sink#18
• MNT Tidy up asset build cwp-starter-theme#211
• FIX Use next-minor installer for next-minor branches gha-generate-matrix#27
• FIX Use injectable version of queuedjobs silverstripe-ldap#42
• DEP Ensure phpunit9 compatible version of segment-field silverstripe-userforms#1159
• MNT Update Utf8TestHelper for MySQL 8.0.30 silverstripe-framework#10426

[GuySartorelli]

I can't reproduce failures in the js builds such as these:

• https://github.com/silverstripe/silverstripe-login-forms/runs/7381641080?check_suite_focus=true
• https://github.com/symbiote/silverstripe-advancedworkflow/runs/7381341198?check_suite_focus=true
  It seems to be compiling something after the git diff commands, which is absolutely bizarre.

I was using nvm use so I'm definitely using the same version of node, and I copy/pasted the commands directly from gha-run-tests to make sure I was doing exactly what CI is doing. It passed fine locally, and didn't have those compiling messages after the git diff.

[GuySartorelli]

I'm unable to reproduce the behat failures in https://github.com/silverstripe/silverstripe-subsites/runs/7381806534?check_suite_focus=true
I've tried having the exact same packages installed, and even though the failures in CI are happening on two different PHP versions and database versions, I've tried matching those as well.

[GuySartorelli]

Builds are green! Whoo!