Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix CI #149

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/gha-ci#37

I think it's still worth keeping the ci.yml file, if only so we don't need to wonder why in the future it has not run for years

@GuySartorelli
Copy link
Member

Might be worth creating a new issue (either here or in gha-ci) to find a way around this, and just have a comment pointing to that issue.
Also probably set this to not run on PRs - it's a bit weird to see a green test on the PR when nothing is actually being tested - it makes it seem like the PR may be safer than it really is and means we're less likely to check, for example, if the dist files are actually in the PR.

@emteknetnz
Copy link
Member Author

It is weird, though I'd rather have a null CI run on pull-requests that no CI at all. That way it's consistent with every other module that has a CI run and we don't need to every investigate why the CI never run.

Have created issue #150

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't like it but it's not the end of the world. I'll merge.

@GuySartorelli GuySartorelli merged commit 384cf2c into silverstripe:3.0 Jul 19, 2022
@GuySartorelli GuySartorelli deleted the pulls/3.0/ci branch July 19, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants