Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Automatically create hardcoded list #20

Merged
merged 1 commit into from
Jul 19, 2022
Merged

ENH Automatically create hardcoded list #20

merged 1 commit into from
Jul 19, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jul 19, 2022
Closed
GuySartorelli
GuySartorelli requested changes Jul 19, 2022
View reviewed changes
hardcoded.php Outdated Show resolved Hide resolved
hardcoded.php Outdated Show resolved Hide resolved
hardcoded.php Outdated Show resolved Hide resolved
consts.php Show resolved Hide resolved
consts.php Show resolved Hide resolved
consts.php Show resolved Hide resolved
hardcoded.php Outdated Show resolved Hide resolved
hardcoded.php Outdated Show resolved Hide resolved
hardcoded.php Show resolved Hide resolved
hardcoded.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1.1/hardcoded branch 2 times, most recently from 1471cda to 6897b52 Compare July 19, 2022 01:11
GuySartorelli
GuySartorelli requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gridfieldextensions seems to be missing? I didn't explicitly check for missing modules so there may be others as well.

consts.php Outdated Show resolved Hide resolved
consts.php Show resolved Hide resolved
consts.php Outdated Show resolved Hide resolved
consts.php Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli mentioned this pull request Jul 19, 2022
Open
@emteknetnz emteknetnz force-pushed the pulls/1.1/hardcoded branch 2 times, most recently from 3e602d5 to 918eab0 Compare July 19, 2022 02:04
GuySartorelli
GuySartorelli requested changes Jul 19, 2022
View reviewed changes
hardcoded.php Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli reviewed Jul 19, 2022
View reviewed changes
hardcoded.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1.1/hardcoded branch 2 times, most recently from 79035e9 to 127c567 Compare July 19, 2022 02:28
GuySartorelli
GuySartorelli requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last change, plus check why gridfieldextensions is missing per my previous comment (and check for other possible missing modules)

hardcoded.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1.1/hardcoded branch 2 times, most recently from a5b5e40 to 45c91d7 Compare July 19, 2022 03:10
GuySartorelli
GuySartorelli requested changes Jul 19, 2022
View reviewed changes
hardcoded.php Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli reviewed Jul 19, 2022
View reviewed changes
consts.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1.1/hardcoded branch from 45c91d7 to 1a5b5b8 Compare July 19, 2022 03:47
@GuySartorelli GuySartorelli merged commit 36e8012 into silverstripe:1.1 Jul 19, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.1/hardcoded branch July 19, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli