Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Regression issue UI URLSegment buttons #1581

Closed
wants to merge 1 commit into from
Closed

FIX Regression issue UI URLSegment buttons #1581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/dist/styles/bundle.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion client/src/styles/_fonts.scss
View file
Open in desktop
Copy link
Contributor Author

@sabina-talipova sabina-talipova Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove whole this block [data-icon]: before, since it looks like doesn't effect [data-icon] elements in CMS UI except "OK" and "Cancel" buttons.
But for now, I just exclude these two elements from a list.

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
font-style: normal;
}

[data-icon]:before {
[data-icon]:not([data-icon="accept"]):not([data-icon="cancel"]):before {
// sass-lint:disable-block no-important
font-family: "silverstripe" !important;
content: attr(data-icon);
Expand Down