FIX Regression issue UI URLSegment buttons #1581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Sep 13, 2023
There was a problem hiding this comment.
I think we can remove whole this block [data-icon]: before, since it looks like doesn't effect [data-icon] elements in CMS UI except "OK" and "Cancel" buttons.
But for now, I just exclude these two elements from a list.
maxime-rainville
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Those classes will be re-imported next time we update our icon font. There's a good chance we'll inadvertently reintroduce this bug.
My instinct would be to remove the data-icon="accept" and data-icon="cancel" attributes on those two button. They don't seem to be serving any purpose anyway.
|
Close. Open silverstripe/silverstripe-cms#2886 |
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue