-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-18524 updated readme and added sample config #74
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
$ tap-google-analytics -c my-config.json -d | ||
``` | ||
|
||
To run he sync mode of `tap-google-analytics` with the catalog file, use the command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in the work "the", eg "To run the sync mode of..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed the typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to include the bookmarking strategy like how tap-square has here https://github.com/singer-io/tap-square.
Added bookmarking strategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion
|
||
How to use it: | ||
- `tap-google-analytics` works together with any other [Singer Target](https://singer.io) to move data from Google Analytics API to any target destination. | ||
- Extracts the following pre-made and any self-made reports from [Google Analytics Reporting API](https://developers.google.com/analytics/devguides/reporting/core/v4/rest/v4/reports/batchGet): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mention the field selection for pre-made reports must follow google's exclusion rule, and point users to the Metrics & Dimensions page https://ga-dev-tools.web.app/dimensions-metrics-explorer/. These rules are handled in the Stitch UI by dynamically marking fields as unsupported as you select a field, but will need to be handled by the user if they wish to run the tap directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note regarding the field exclusion and also added the reference link for the same.
Description of change
QA steps
Risks
Rollback steps