Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-18524 updated readme and added sample config #74

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

namrata270998
Copy link
Contributor

Description of change

  • Updated the readme file and added sample config

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

@namrata270998 namrata270998 changed the title updated readme and added sample config TDL-18524 updated readme and added sample config Apr 21, 2022
README.md Outdated
$ tap-google-analytics -c my-config.json -d
```

To run he sync mode of `tap-google-analytics` with the catalog file, use the command:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in the work "the", eg "To run the sync mode of..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed the typo

@namrata270998 namrata270998 requested a review from dsprayberry May 9, 2022 13:47
Copy link
Contributor

@kspeer825 kspeer825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to include the bookmarking strategy like how tap-square has here https://github.com/singer-io/tap-square.

@namrata270998
Copy link
Contributor Author

Would be good to include the bookmarking strategy like how tap-square has here https://github.com/singer-io/tap-square.

Added bookmarking strategy

@namrata270998 namrata270998 requested a review from kspeer825 May 30, 2022 13:01
Copy link
Contributor

@kspeer825 kspeer825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion


How to use it:
- `tap-google-analytics` works together with any other [Singer Target](https://singer.io) to move data from Google Analytics API to any target destination.
- Extracts the following pre-made and any self-made reports from [Google Analytics Reporting API](https://developers.google.com/analytics/devguides/reporting/core/v4/rest/v4/reports/batchGet):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention the field selection for pre-made reports must follow google's exclusion rule, and point users to the Metrics & Dimensions page https://ga-dev-tools.web.app/dimensions-metrics-explorer/. These rules are handled in the Stitch UI by dynamically marking fields as unsupported as you select a field, but will need to be handled by the user if they wish to run the tap directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note regarding the field exclusion and also added the reference link for the same.

@namrata270998 namrata270998 requested a review from kspeer825 June 1, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants