-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-18524 updated readme and added sample config #74
Open
namrata270998
wants to merge
9
commits into
master
Choose a base branch
from
TDL-18524-update-readme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
256274c
updated readme and added sample config
namrata270998 2ec89c9
added discover and sync mode details
namrata270998 d6d48c6
removed the 'for dev' word
namrata270998 a59405b
added mor specific details regarding auth
namrata270998 b74d904
updated endpoints
namrata270998 98168e6
updated fornatting
namrata270998 fe0b060
fixed the typo
namrata270998 67af3f2
added bookmarking in readme
namrata270998 f3460fd
added field exclusion note in readme
namrata270998 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"start_date": "2021-11-22T00:00:00Z", | ||
"report_definitions": [ | ||
{ | ||
"id": "report_id", | ||
"name": "Report Name" | ||
} | ||
], | ||
"refresh_token": "my_token", | ||
"client_id": "client_id", | ||
"client_secret": "client_secret", | ||
"auth_method": "oauth2" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mention the field selection for pre-made reports must follow google's exclusion rule, and point users to the Metrics & Dimensions page https://ga-dev-tools.web.app/dimensions-metrics-explorer/. These rules are handled in the Stitch UI by dynamically marking fields as unsupported as you select a field, but will need to be handled by the user if they wish to run the tap directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note regarding the field exclusion and also added the reference link for the same.