Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema for tickets.json #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

melnimr
Copy link

@melnimr melnimr commented Sep 26, 2019

Add types to the value structure to adhere to the Singer specs.

Add types to the value structure to adhere to the Singer specs.
@cmerrick
Copy link
Contributor

Hi @melnimr, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @melnimr!

Thank you for signing the Singer Contribution License Agreement.

@luandy64
Copy link
Contributor

Looking at the docs, this PR would cause issues for people who have custom field values that are anything but strings (like numerics or arrays).

If you really need this in the schema, I recommend you fork this repo and run the tap yourself with the change.

@leo-schick
Copy link

@luandy64 You are right. Arrays do not work so this should be changed to:

"value": {
  "type":  ["null", "string", "array"],
  "items": {
    "type": ["null", "string"]
  }
}

It looks like that the API sends the numeric type as string.

Here are my used custom fields:
image

For the numeric field I got {"id": 360004765077, "value": "10517014"}.

The above definition worked for me with my custom fields setup shown above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants