Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PUSH0 instruction to EVM #1700

Closed
Tracked by #1694
kladkogex opened this issue Oct 19, 2023 · 3 comments · Fixed by #1709
Closed
Tracked by #1694

Add PUSH0 instruction to EVM #1700

kladkogex opened this issue Oct 19, 2023 · 3 comments · Fixed by #1709
Assignees
@kladkogex
Labels
epic:eth-compatibility
Milestone
SKALE 2.3

Comments

@kladkogex
Copy link
Collaborator

Add support for PUSH0 in Shanghai fork.

Solidity compiler version 0.8.20 uses lots of PUSH0 instructions by default
@kladkogex kladkogex linked a pull request Oct 19, 2023 that will close this issue
1700 push zero #1701
Closed
@PolinaKiporenko PolinaKiporenko mentioned this issue Oct 20, 2023
Closed
@PolinaKiporenko PolinaKiporenko added this to the SKALE 2.3 milestone Oct 20, 2023
@PolinaKiporenko PolinaKiporenko moved this to Ready For Pickup in SKALE Engineering 🚀 Oct 20, 2023
This was linked to pull requests Oct 23, 2023
1664 eth trace current #1708
Closed
1700 push zero #1709
Merged
kladkogex added a commit that referenced this issue Oct 24, 2023
@kladkogex
#1700 Fast forward consensus
4d59da9
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to Code Review in SKALE Engineering 🚀 Nov 2, 2023
@kladkogex kladkogex removed a link to a pull request Nov 27, 2023
1664 eth trace current #1708
Closed
@DmytroNazarenko DmytroNazarenko moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Dec 5, 2023
@oleksandrSydorenkoJ

This comment was marked as resolved.

Sign in to view
@DmytroNazarenko
Copy link
Collaborator

skaled: 3.18.0-beta.0
patch: pushZeroPatchTimestamp

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jan 23, 2024
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jan 23, 2024
@oleksandrSydorenkoJ
Copy link

oleksandrSydorenkoJ commented Jan 29, 2024 •
edited
Loading

Verified on Regression network
Skale chain aged-wry-finished-skale
Example Contract

skalenetwork/schain:3.18.0-beta.0 after patchTimestamp:

> eth.getTransactionReceipt('0xd9c17751f56f36404c1c0792dc3b2d152b9a2fc000025e9d67756397a9c9d7b6')
{
  blockHash: "0x079117064c9093a2b4fe7609451bd74de4635304979b63085e0154ddf0d0ad9b",
  blockNumber: 38406,
  contractAddress: "0x02a9c265bd7fe84dee84fff12857b9be706d5522",
  cumulativeGasUsed: 1086877,
  from: "0x71cbe3fede33905d4d1bf2bd51f9d4a62375e659",
  gasUsed: 297613,
  logs: [],
  logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  status: "0x1",
  to: "0x0000000000000000000000000000000000000000",
  transactionHash: "0xd9c17751f56f36404c1c0792dc3b2d152b9a2fc000025e9d67756397a9c9d7b6",
  transactionIndex: 8
}
> eth.getCode('0x02a9c265bd7fe84dee84fff12857b9be706d5522')
"0x608060405234801561000f575f80fd5b506004361061004a575f3560e01c806327e235e31461004e5780636057361d1461007e5780638da5cb5b1461009a578063c0fe1af8146100b8575b5f80fd5b61006860048036038101906100639190610255565b6100d4565b6040516100759190610298565b60405180910390f35b610098600480360381019061009391906102db565b6100ea565b005b6100a2610125565b6040516100af9190610315565b60405180910390f35b6100d260048036038101906100cd91906102db565b610148565b005b610102602052805f5260405f205f915090505481565b8060016101015461010081106101035761010261032e565b5b018190555060016101015f82825461011b9190610388565b9250508190555050565b5f8054906101000a900473ffffffffffffffffffffffffffffffffffffffff1681565b5f6101025f3373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020015f205490505f60018361010081106101a05761019f61032e565b5b01819055503373ffffffffffffffffffffffffffffffffffffffff167f03906040b4381d084a7665e32d3f98d85db62f34682f5dd9361f34304226adb3826040516101eb9190610298565b60405180910390a25050565b5f80fd5b5f73ffffffffffffffffffffffffffffffffffffffff82169050919050565b5f610224826101fb565b9050919050565b6102348161021a565b811461023e575f80fd5b50565b5f8135905061024f8161022b565b92915050565b5f6020828403121561026a576102696101f7565b5b5f61027784828501610241565b91505092915050565b5f819050919050565b61029281610280565b82525050565b5f6020820190506102ab5f830184610289565b92915050565b6102ba81610280565b81146102c4575f80fd5b50565b5f813590506102d5816102b1565b92915050565b5f602082840312156102f0576102ef6101f7565b5b5f6102fd848285016102c7565b91505092915050565b61030f8161021a565b82525050565b5f6020820190506103285f830184610306565b92915050565b7f4e487b71000000000000000000000000000000000000000000000000000000005f52603260045260245ffd5b7f4e487b71000000000000000000000000000000000000000000000000000000005f52601160045260245ffd5b5f61039282610280565b915061039d83610280565b92508282019050808211156103b5576103b461035b565b5b9291505056fea264697066735822122068d0d7a06726c96fe59e536a19969e34e4a526545bd50844e9537cfb33d476d664736f6c63430008180033"

skalenetwork/schain:3.17.1

> eth.getTransactionReceipt('0xd9c17751f56f36404c1c0792dc3b2d152b9a2fc000025e9d67756397a9c9d7b6')
{
  blockHash: "0x2ceea1a533c8c7a5adedebb46052be7da674153db8353c32bd3efe44b6e9eadd",
  blockNumber: 38406,
  contractAddress: "0x02a9c265bd7fe84dee84fff12857b9be706d5522",
  cumulativeGasUsed: 1086877,
  from: "0x71cbe3fede33905d4d1bf2bd51f9d4a62375e659",
  gasUsed: 297613,
  logs: [],
  logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  status: "0x0",
  to: "0x0000000000000000000000000000000000000000",
  transactionHash: "0xd9c17751f56f36404c1c0792dc3b2d152b9a2fc000025e9d67756397a9c9d7b6",
  transactionIndex: 8
}
> eth.getCode('0x02a9c265bd7fe84dee84fff12857b9be706d5522')
"0x"

@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kladkogex kladkogex

Labels
epic:eth-compatibility
Projects
SKALE Engineering 🚀
Archived in project
Milestone
SKALE 2.3
Development

Successfully merging a pull request may close this issue.

1700 push zero skalenetwork/skaled
1700 push zero skalenetwork/skaled
4 participants
@kladkogex @DmytroNazarenko @oleksandrSydorenkoJ @PolinaKiporenko