Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1700 push zero #1701

Closed
wants to merge 37 commits into from
Closed

1700 push zero #1701

wants to merge 37 commits into from

Conversation

kladkogex
Copy link
Collaborator

Adds PUSH0 instruction, that pushes zero byte on EVM stack.

See comments in code.

A new test has been added to test PUSH0

To run the test

  1. Run skaled

build/skaled/skaled -v4 --config test/historicstate/configs/basic_config.json


  1. Run test

  2. npx hardhat run test/historicstate/hardhat/scripts/push0_test.ts --network skaled

Enabling PUSH0 requires setting the patch time stamp

  "pushZeroPatchTimestamp": 1

DmytroNazarenko and others added 27 commits July 4, 2023 13:21
…arams-eth-block-number

Bug/bug 1198 dont ignore params eth block number
1482 update consensus for db usage call fix
@kladkogex kladkogex self-assigned this Oct 19, 2023
@kladkogex kladkogex linked an issue Oct 19, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1701 (4d59da9) into develop (ff99191) will decrease coverage by 0.12%.
Report is 13 commits behind head on develop.
The diff coverage is 51.85%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1701      +/-   ##
===========================================
- Coverage    45.25%   45.13%   -0.12%     
===========================================
  Files          349      351       +2     
  Lines        51405    51430      +25     
===========================================
- Hits         23263    23213      -50     
- Misses       28142    28217      +75     

@kladkogex kladkogex closed this Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PUSH0 instruction to EVM
4 participants