Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1700 push zero #1709

Merged
merged 12 commits into from
Oct 24, 2023
Merged

1700 push zero #1709

merged 12 commits into from
Oct 24, 2023

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Oct 24, 2023 •
edited by DmytroNazarenko
Loading

This has been reviewed already

Path timestamp: pushZeroPatchTimestamp
See the tests in tests/historicstate/hardhat/scripts/push0_test.ts

@kladkogex kladkogex added this to the 2.3 milestone Oct 24, 2023
@kladkogex kladkogex self-assigned this Oct 24, 2023
@kladkogex kladkogex linked an issue Oct 24, 2023 that may be closed by this pull request
Add PUSH0 instruction to EVM #1700
Closed
@kladkogex kladkogex requested a review from DimaStebaev October 24, 2023 10:31
@DmytroNazarenko DmytroNazarenko removed this from the 2.3 milestone Oct 24, 2023
dimalit
dimalit previously approved these changes Oct 24, 2023
View reviewed changes
DmytroNazarenko
DmytroNazarenko requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested. Let's create a custom build and check it on the devnet before merge

test/historicstate/hardhat/scripts/push0_test.ts Outdated Show resolved Hide resolved
test/historicstate/hardhat/scripts/push0_test.ts Outdated Show resolved Hide resolved
libevm/LegacyVM.cpp Show resolved Hide resolved
libconsensus Outdated Show resolved Hide resolved
DmytroNazarenko
DmytroNazarenko approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on devnet

@kladkogex kladkogex merged commit 4c87471 into v3.18.0 Oct 24, 2023
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiy-skalelabs sergiy-skalelabs sergiy-skalelabs approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@dimalit dimalit dimalit left review comments

@DimaStebaev DimaStebaev Awaiting requested review from DimaStebaev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PUSH0 instruction to EVM
4 participants
@kladkogex @dimalit @DmytroNazarenko @sergiy-skalelabs