Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: set 3.8 as min python version (3.7 eol), and add python 3.11 runs to automated testing #1135

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nstelter-slac
Copy link
Collaborator

No description provided.

@nstelter-slac
Copy link
Collaborator Author

nstelter-slac commented Dec 4, 2024

@jbellister-slac
Copy link
Collaborator

might need to start pulling p4p from PyPI. The version on conda-forge stopped updating a while ago (3.5.5) while the newest version is 4.2.0.

https://pypi.org/project/p4p/

@ZLLentz
Copy link
Member

ZLLentz commented Dec 4, 2024

I also pull p4p from pypi for this reason (in our conda environments)

The pypi p4p builds seem to work up through python 3.12

@nstelter-slac
Copy link
Collaborator Author

nstelter-slac commented Dec 4, 2024

oh looks like we actually get p4p from pip:

i think its just the automated-test setup that conda-installs the pip packages from dev-requirements.txt (this is weird)?

mamba install pyqt=${{ matrix.pyqt-version }} $(cat requirements.txt dev-requirements.txt)

@nstelter-slac
Copy link
Collaborator Author

nstelter-slac commented Dec 4, 2024

i did some testing by creating this conda env:

conda create -n pydm-environment python=3.11 pyqt=5 pip numpy scipy six psutil pyqtgraph pydm -c conda-forge (3.11 requires unpinning pyqt from 5.12.3)

then did the usual pip install setups in pydm repo (gets me pip show p4p = 4.2.0)

some tests pass but then getting odd failures on some tests, for ex:

ERROR    pydm.data_plugins:__init__.py:96 Could not find protocol for 'fake://tst'
Traceback (most recent call last):
  File "/home/nolan-work/repos/pydm/pydm/data_plugins/__init__.py", line 94, in plugin_for_address
    return plugin_modules[str(protocol)]
           ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: 'fake'
ERROR    pydm.data_plugins:__init__.py:98 Channel fake://tst did not specify a valid protocol and no default protocol is defined. This channel will receive no data. To specify a default protocol, set the PYDM_DEFAULT_PROTOCOL environment variable.
ERROR    pydm.widgets.channel:channel.py:154 Unable to make proper connection for <PyDMChannel (fake://tst)>

weird, i actually get these issues starting with python 3.10 (although automation currently tests 3.10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants