Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: set 3.8 as min python version (3.7 eol), and add python 3.11 runs to automated testing #1135

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

MNT: set 3.8 as min python version (3.7 eol), and add python 3.11 runs to automated testing #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64454e5
MNT: set 3.8 as min python version (since 3.7 eol), add python 3.11,3…
nstelter-slac Dec 4, 2024
827211e
MNT: make gh actions install python dependencies using pip, so correc…
nstelter-slac Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.8', '3.9', '3.10']
pyqt-version: [5.12.3, 5.15.9]
pyqt-version: [5.12.3]
env:
DISPLAY: ':99.0'
QT_MAC_WANTS_LAYER: 1 # PyQT gui tests involving qtbot interaction on macOS will fail without this
Expand All @@ -35,16 +35,19 @@ jobs:
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: pydm-env
- name: Install pyqt with mamba
shell: bash -el {0}
run: |
mamba install pyqt=${{ matrix.pyqt-version }}
- name: Install python packages
shell: bash -el {0}
run: |
if [ "$RUNNER_OS" == "Windows" ]; then
mamba install pyqt=${{ matrix.pyqt-version }}
mamba install --file requirements.txt --file windows-dev-requirements.txt
python -m pip install -r requirements.txt -r windows-dev-requirements.txt
else
mamba install pyqt=${{ matrix.pyqt-version }} $(cat requirements.txt dev-requirements.txt)
python -m pip install -r requirements.txt -r dev-requirements.txt
fi
- name: Install packages for testing a pyqt app on linux
- name: Install packages for testing a pyqt app on linux, start the display server + window manager
shell: bash -el {0}
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ as the abstraction layer for the Qt Python wrappers (PyQt5/PyQt4/PySide2/PySide)
**All tests are performed with PyQt5**.

# Prerequisites
* Python 3.7+
* Python 3.8+
* Qt 5.6 or higher
* qtpy
* PyQt5 >= 5.7 or any other Qt Python wrapper.
Expand Down
4 changes: 2 additions & 2 deletions conda-recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ build:

requirements:
host:
- python
- python >=3.8
- pip
- setuptools
- pyqt =5
- qtpy
run:
- python
- python >=3.8
- six
- numpy
- scipy
Expand Down
Loading