GO-130 Migrate tags from MessageDraft to associated Message #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Oct 15, 2024
jsuchal
reviewed
Oct 15, 2024
app/models/govbox/message.rb
Outdated
| @@ -27,6 +27,8 @@ class Govbox::Message < ApplicationRecord | |||
|
|
|||
| def self.create_message_with_thread!(govbox_message) | |||
| message = nil | |||
| message_draft = Upvs::MessageDraft.where(uuid: govbox_message.message_id).joins(:thread).where(thread: { box_id: govbox_message.box.id }).take | |||
| tags_to_migrate = message_draft&.tags_to_migrate_to_message | |||
There was a problem hiding this comment.
Tato migracia tagov sa mi zda taka "rozbita". Nevieme to nejako zabalit do metody, ktora tu urobi v ramci toho advisory_lock?
There was a problem hiding this comment.
Hej, nebolo to dobre. Ten deferred constraint pomohol a zbavili sme sa tych skaredych casti podla mna.
jsuchal
reviewed
Oct 15, 2024
jsuchal
reviewed
Oct 28, 2024
app/models/govbox/message.rb
Outdated
|
|
||
| MessageThread.with_advisory_lock!(govbox_message.correlation_id, transaction: true, timeout_seconds: 10) do | ||
| message = create_message(govbox_message) | ||
|
|
||
| message.thread = govbox_message.box.message_threads.find_or_create_by_merge_uuid!( | ||
| message.thread = (message_draft.thread if message_draft) || govbox_message.box.message_threads.find_or_create_by_merge_uuid!( |
There was a problem hiding this comment.
Nerozdelime to na dva riadky?
Suggested change
| message.thread = (message_draft.thread if message_draft) || govbox_message.box.message_threads.find_or_create_by_merge_uuid!( | |
| message.thread = message_draft&.thread | |
| message.thread ||= govbox_message.box.message_threads.find_or_create_by_merge_uuid!( |
jsuchal
reviewed
Oct 28, 2024
app/models/govbox/message.rb
Outdated
| add_upvs_related_tags(message, govbox_message) | ||
| end | ||
| migrate_tags_from_draft(message, message_draft) if message_draft |
There was a problem hiding this comment.
Toto ked posunieme o riadok nizsie, tak to vieme zabalit do jedneho if?
jsuchal
reviewed
Oct 28, 2024
app/models/govbox/message.rb
Outdated
| @@ -140,6 +145,15 @@ def self.add_upvs_related_tags(message, govbox_message) | |||
| add_delivery_notification_tag(message) if message.can_be_authorized? | |||
| end | |||
|
|
|||
| def self.migrate_tags_from_draft(message, message_draft) | |||
There was a problem hiding this comment.
migrate znie divne, skor copy_tags_from_message (asi je jedno ci to je draft alebo nie nie?
jsuchal
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.