-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the KIDA UVA 2014 network to Astrochem format #38
Open
smaret
wants to merge
8
commits into
master
Choose a base branch
from
kida
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format used in KIDA network as changed. Fix the fromfile() method accordingly.
If the network file contain some validity range for the temperature, include it in the reaction object. For the moment only KIDA networks are supported.
With this option, the reactions that are not valid at a given temperature are ignored. This allows to convert networks from KIDA that contain several reaction rates for each reaction, which each of this rate corresponding to a different temperature range.
It looks like the reaction types / formulae in KIDA have changed: photodissociation used to be 3, and it's now 2. There are also two new types, |
The KIDA UVA 2014 network also contain an (undocumented) type 0 which corresponds to type -1 in OSU. There are also types 10 and 11 for H2 formation. |
f288003
to
e72d27d
Compare
Related issue: #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the conversion of the KIDA UVA 2014 network to Astrochem format, and its inclusion in the distribution. There are several points to adress: