Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Flakeguard reports: Split commands and use data and presentation layers #1435

Merged
merged 24 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 0 additions & 100 deletions tools/flakeguard/cmd/aggregate_results.go

This file was deleted.

4 changes: 3 additions & 1 deletion tools/flakeguard/cmd/check_test_owners.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ var CheckTestOwnersCmd = &cobra.Command{
Use: "check-test-owners",
Short: "Check which tests in the project do not have code owners",
RunE: func(cmd *cobra.Command, args []string) error {
projectPath, _ := cmd.Flags().GetString("project-path")

// Scan project for test functions
testFileMap, err := reports.ScanTestFiles(projectPath)
if err != nil {
Expand Down Expand Up @@ -79,7 +81,7 @@ var CheckTestOwnersCmd = &cobra.Command{
}

func init() {
CheckTestOwnersCmd.Flags().StringVarP(&projectPath, "project-path", "p", ".", "Path to the root of the project")
CheckTestOwnersCmd.Flags().StringP("project-path", "p", ".", "Path to the root of the project")
CheckTestOwnersCmd.Flags().StringVarP(&codeownersPath, "codeowners-path", "c", ".github/CODEOWNERS", "Path to the CODEOWNERS file")
CheckTestOwnersCmd.Flags().BoolVarP(&printTestFunctions, "print-test-functions", "t", false, "Print all test functions without owners")
}
Loading
Loading