Suppress flaky integ tests #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves some integ tests that were incorrectly put into unit tests and additionally marks them as skipped. They're being skipped because they've become flaky, likely due to some changes on the host side that we can't control. They should ultimately be replaced with unit tests.
JordonPhillips
force-pushed
the
fix-http-2-tests
branch
from
69518ec
to
ccc13e7
Compare
nateprewitt
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some integ tests that were incorrectly put into unit tests and additionally marks them as skipped. They're being skipped because they've become flaky, likely due to some changes on the host side that we can't control. They should ultimately be replaced with unit tests.
Note that protocol tests will be failing until #270 is merged.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.