-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types and code generation for event stream operation signatures #318
Conversation
66caf5d
to
ff1df13
Compare
I also had to add suppressions for new protocol tests that assert http-binding behaviors. We'll be re-writing all that binding code soon, so there's little value in fixing it now. |
8ab8068
to
2337eea
Compare
2337eea
to
9a65cc0
Compare
I split the suppressions out into another pr since it was blocking everything |
This adds in the EventStream interfaces that operations will use as their return types.
This adds a bidirectional event stream to the test package so that new code generation for event streams can be examined.
This updates operation generation to generate event stream operations with the EventStream type as its return value. It also updates union generation so that unions contain their own deserialize functions. This is needed to make the them pass the type check, but also it is best to have them own as much of that as possible so that the deserializer function can be left to only dispatch duty.
9a65cc0
to
ae059da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple typos, otherwise looks good.
python-packages/smithy-event-stream/smithy_event_stream/aio/interfaces.py
Outdated
Show resolved
Hide resolved
python-packages/smithy-event-stream/smithy_event_stream/aio/interfaces.py
Outdated
Show resolved
Hide resolved
Fix comment typos Co-authored-by: Nate Prewitt <[email protected]>
No idea why codecov ate it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a transient 503 for CodeCov, succeeded on retry.
This adds in the interfaces for event streams and updates code generation to use them.
Example generated operation:
These were part of separate prs that included http context, which has been removed. Doc strings have also been majorly beefed up. Example useage from the beefed up docs:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.