Bump MSRV to 1.81.0 #3936
Merged
Bump MSRV to 1.81.0 #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Mostly doc changes to align with the new doc indentation lints https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This PR modifies `aws-smithy-types::DateTime` to enforce the use of 'T' (or 't') as the date-time separator. A [recent merge](https://github.com/time-rs/time/pull/700/files#diff-78a73b9911c88961601784e674a20c89e7050de9f8763522bbaa88ed28311b51R524) in the 'time' crate introduced support for space characters as separators. While ISO 8601 does allow spaces, RFC 3339 strictly requires 'T' (or 't') as the separator. This change restores the behavior to match how it was before `time = 0.3.37`. This PR also removes the temporary pinning of the time crate in protocol tests. Co-authored-by: Fahad Zubair <[email protected]>
If CI fails, commit the necessary fixes to this PR until all checks pass. If changes are required to [crateNameToLastKnownWorkingVersions](https://github.com/smithy-lang/smithy-rs/blob/92916b5484cdfef9ff58540ebf5e845eeeccf860/aws/sdk/build.gradle.kts#L504), revert the first commit in the PR, run `./gradlew aws:sdk:cargoUpdateAllLockfiles`, and commit the updated lockfiles. Co-authored-by: Landon James <[email protected]> Co-authored-by: ysaito1001 <[email protected]>
## Motivation and Context This example doesn't reflect the token generation API accurately, this PR fixes that. ## Description Fix the example by using the right API. ## Testing Documentation update on an ignored code block, no testing required ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
landonxjames
force-pushed
the
landonxjames/msrv-bump
branch
from
a1f1ec6 to
8875815
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
If CI fails, commit the necessary fixes to this PR until all checks pass. If changes are required to [crateNameToLastKnownWorkingVersions](https://github.com/smithy-lang/smithy-rs/blob/92916b5484cdfef9ff58540ebf5e845eeeccf860/aws/sdk/build.gradle.kts#L504), revert the first commit in the PR, run `./gradlew aws:sdk:cargoUpdateAllLockfiles`, and commit the updated lockfiles. Co-authored-by: Landon James <[email protected]> Co-authored-by: ysaito1001 <[email protected]>
landonxjames
force-pushed
the
landonxjames/msrv-bump
branch
from
a89d950 to
ca0af4e
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
force-pushed
the
landonxjames/msrv-bump
branch
from
9da0637 to
c73182a
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
If CI fails, commit the necessary fixes to this PR until all checks pass. If changes are required to [crateNameToLastKnownWorkingVersions](https://github.com/smithy-lang/smithy-rs/blob/92916b5484cdfef9ff58540ebf5e845eeeccf860/aws/sdk/build.gradle.kts#L504), revert the first commit in the PR, run `./gradlew aws:sdk:cargoUpdateAllLockfiles`, and commit the updated lockfiles.
aajtodd
approved these changes
Dec 16, 2024
This reverts commit c73182a.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.