Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ocu 186 docs minor fixes in dracon oss #337

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Feature/ocu 186 docs minor fixes in dracon oss #337

merged 7 commits into from
Sep 5, 2024

Conversation

andream16
Copy link
Contributor

Fixes:

  • Links and formatting issues in README and getting started docs.
  • Fixes incorrect/malformed commands in the getting started docs.
  • Fixes an error highlighted by Helm caused by a missing key database in the dev.yam values file
  • Ignores .idea/ like we ignore .vscode

@andream16 andream16 self-assigned this Sep 4, 2024
andream16
andream16 commented Sep 4, 2024
View reviewed changes
northdpole
northdpole reviewed Sep 4, 2024
View reviewed changes
northdpole
northdpole reviewed Sep 4, 2024
View reviewed changes
dlicheva
dlicheva approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@dlicheva dlicheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌

northdpole
northdpole approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@northdpole northdpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with comments as the comments are mostly on future work/tickets

@linear linear bot mentioned this pull request Sep 5, 2024
Open
@andream16 andream16 force-pushed the feature/ocu-186-docs-minor-fixes-in-dracon-oss branch from 3637c56 to a64b5be Compare September 5, 2024 11:28
@andream16 andream16 force-pushed the feature/ocu-186-docs-minor-fixes-in-dracon-oss branch from a64b5be to 5213242 Compare September 5, 2024 13:32
@ptzianos ptzianos merged commit 4fe6167 into main Sep 5, 2024
3 checks passed
@ptzianos ptzianos deleted the feature/ocu-186-docs-minor-fixes-in-dracon-oss branch September 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@northdpole northdpole northdpole approved these changes

@ptzianos ptzianos ptzianos approved these changes

@dlicheva dlicheva dlicheva approved these changes

Assignees

@andream16 andream16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andream16 @northdpole @ptzianos @dlicheva