Use PHP 8.1 never return type #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the `@return never` docstring used by some CI tools. Related to smrealms#1183.
Codecov Report
@@ Coverage Diff @@
## main #1184 +/- ##
=========================================
Coverage 14.47% 14.47%
Complexity 3927 3927
=========================================
Files 85 85
Lines 11630 11630
=========================================
Hits 1683 1683
Misses 9947 9947
Continue to review full report at Codecov.
|
|
Note that Scrutinizer does not yet know about the |
hemberger
added a commit
that referenced
this pull request
May 3, 2022
We have been using PHP 8.1 since #1176 (and implicitly requiring it since #1184), but I forgot to bump the Composer requirement. I discovered this coincidentally when Dependabot was failing to update `overtrue/phplint` beyond v4.1.0. While investigating, I remembered seeing that their v5.0.0 release had a PHP 8.1 requirement, which made Dependabot think it was incompatible with our project due to the (incorrect) 8.0+ requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
@return neverdocstring used by some CI tools.Related to #1183.